Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to plat linuxu and dead links #446

Merged
merged 3 commits into from
Aug 9, 2024
Merged

Remove references to plat linuxu and dead links #446

merged 3 commits into from
Aug 9, 2024

Conversation

tatodorov
Copy link
Contributor

No description provided.

Copy link
Member

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tatodorov. The changes look good, but please sign-off your commits and follow the commits naming scheme that is used for the rest of the repository (e.g. docs/: Remove references to linuxu)

@tatodorov tatodorov requested a review from StefanJum July 24, 2024 03:03
@MaD70
Copy link

MaD70 commented Aug 8, 2024

I was about to file an issue regarding the missing linuxu page linked from https://unikraft.org/docs/concepts/virtualization, that one of these commits have already removed but whose merge has been blocked.

Please, unblock it or take some other appropriate action.

@razvand razvand self-assigned this Aug 9, 2024
Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See may comments. Also remove the trailing slash (/) from the prefix of the commit message. i.e. replace docs/: with docs:.

content/docs/concepts/virtualization.mdx Outdated Show resolved Hide resolved
content/docs/internals/booting.mdx Outdated Show resolved Hide resolved
content/docs/contributing/unikraft.mdx Outdated Show resolved Hide resolved
content/docs/concepts/virtualization.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Razvan Deaconescu razvand@unikraft.io
Approved-by: Razvan Deaconescu razvand@unikraft.io

@razvand razvand added the enhancement New feature or request label Aug 9, 2024
Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove trailing whitespaces.

Remove linuxu refereces in guides/debugging

Platform linuxu has been removed in Unikraft 0.17.

Signed-off-by: Todor Todorov <todor@todorov.uk>
Signed-off-by: Todor Todorov <todor@todorov.uk>
@razvand razvand self-requested a review August 9, 2024 12:10
Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Razvan Deaconescu razvand@unikraft.io
Approved-by: Razvan Deaconescu mailto:razvand@unikraft.io

@razvand razvand merged commit ce1c71b into unikraft:main Aug 9, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants